Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289054

Re: vmstat: make vmstat_updater deferrable again and shut down on idle

Show all headers | View raw

On Thu, 10 Dec 2015, Andrew Morton wrote:

> >  /*
> > + * Switch off vmstat processing and then fold all the remaining differentials
> > + * until the diffs stay at zero. The function is used by NOHZ and can only be
> > + * invoked when tick processing is not active.
> > + */
> > +void quiet_vmstat(void)
> > +{
> > +	do {
> > +		if (!cpumask_test_and_set_cpu(smp_processor_id(), cpu_stat_off))
> > +			cancel_delayed_work(this_cpu_ptr(&vmstat_work));
> > +
> > +	} while (refresh_cpu_vm_stats(false));
> > +}
>
> How do we know this will terminate in a reasonable amount of time if
> other CPUs are pounding away?

This is only dealing with the differentials of the local cpu. Other cpus
do not matter.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

vmstat: make vmstat_updater deferrable again and shut down on idle Christoph Lameter <cl@linux.com> - 2015-12-10 22:00 +0100
  Re: vmstat: make vmstat_updater deferrable again and shut down on  idle Andrew Morton <akpm@linux-foundation.org> - 2015-12-11 00:40 +0100
    Re: vmstat: make vmstat_updater deferrable again and shut down on  idle Christoph Lameter <cl@linux.com> - 2015-12-11 02:50 +0100

csiph-web