Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG
Date	2015-12-10 15:10 +0100
Message-ID	<qEa4X-7fV-7@gated-at.bofh.it> (permalink)
References	<qDvl8-5U7-11@gated-at.bofh.it> <qDvl9-5U7-45@gated-at.bofh.it> <qE9iz-6It-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 10, 2015 at 02:17:18PM +0100, Michal Hocko wrote:
> On Tue 08-12-15 13:34:23, Johannes Weiner wrote:
> > The cgroup2 memory controller will account important in-kernel memory
> > consumers per default. Move all necessary components to CONFIG_MEMCG.
> 
> Hmm, that bloats the kernel also for users who are not using cgroup2
> and have CONFIG_MEMCG_KMEM disabled.

Huh? The clock is ticking for them. We'll keep the original cgroup
interface around for backwards compatibility as long as we think there
are activer users, but this is not the time to microoptimize v1. A
slight increase to kernel size is unfortunate, but I don't think this
could be considered a regression in the sense that it breaks anything.

I'm more concerned with cgroup2 users having to pay the excessive cost
of v1-only features, like the entire soft limit implementation, charge
migration, which also has its fangs in VM hotpaths, the eventfd stuff,
arbitrarily-configurable usage thresholds. That's a *ton* of code. If
you want to tackle kernel bloat, grouping this stuff all together and
slapping a CONFIG_MEMCG_LEGACY around it would be a real step forward.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/8] mm: memcontrol: account "kmem" in cgroup2 Johannes Weiner <hannes@cmpxchg.org> - 2015-12-08 19:40 +0100
  [PATCH 1/8] mm: memcontrol: drop unused @css argument in memcg_init_kmem Johannes Weiner <hannes@cmpxchg.org> - 2015-12-08 19:40 +0100
    Re: [PATCH 1/8] mm: memcontrol: drop unused @css argument in  memcg_init_kmem Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-12-09 10:10 +0100
    Re: [PATCH 1/8] mm: memcontrol: drop unused @css argument in  memcg_init_kmem Michal Hocko <mhocko@kernel.org> - 2015-12-10 13:40 +0100
  [PATCH 8/8] mm: memcontrol: introduce CONFIG_MEMCG_LEGACY_KMEM Johannes Weiner <hannes@cmpxchg.org> - 2015-12-08 19:40 +0100
    Re: [PATCH 8/8] mm: memcontrol: introduce CONFIG_MEMCG_LEGACY_KMEM Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-12-09 12:40 +0100
  [PATCH 4/8] mm: memcontrol: group kmem init and exit functions together Johannes Weiner <hannes@cmpxchg.org> - 2015-12-08 19:40 +0100
    Re: [PATCH 4/8] mm: memcontrol: group kmem init and exit functions  together Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-12-09 10:20 +0100
    Re: [PATCH 4/8] mm: memcontrol: group kmem init and exit functions  together Michal Hocko <mhocko@kernel.org> - 2015-12-10 14:00 +0100
  [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG Johannes Weiner <hannes@cmpxchg.org> - 2015-12-08 19:40 +0100
    Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to  CONFIG_MEMCG Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-12-09 10:40 +0100
    Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to  CONFIG_MEMCG Michal Hocko <mhocko@kernel.org> - 2015-12-10 14:20 +0100
      Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to  CONFIG_MEMCG Johannes Weiner <hannes@cmpxchg.org> - 2015-12-10 15:10 +0100
    [PATCH 6/8 v2] mm: memcontrol: move kmem accounting code to  CONFIG_MEMCG Johannes Weiner <hannes@cmpxchg.org> - 2015-12-10 21:30 +0100
      Re: [PATCH 6/8 v2] mm: memcontrol: move kmem accounting code to  CONFIG_MEMCG Johannes Weiner <hannes@cmpxchg.org> - 2015-12-10 22:00 +0100

csiph-web