Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290235

Re: [PATCH v2] I2C: designware: fix IO timeout issue for AMD controller

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Dec 11, 2015 at 08:02:53PM +0800, Xiangliang Yu wrote:
> Because of some hardware limitation, AMD I2C controller can't
> trigger pending interrupt if interrupt status has been changed
> after clearing interrupt status bits. Then, I2C will lost
> interrupt and IO timeout.
> 
> According to hardware design, this patch implements a workaround
> to disable i2c controller interrupt and re-enable i2c interrupt
> before exiting ISR.
> 
> To reduce the performance impacts on other vendors, use unlikely
> function to check flag in ISR.
> ---

Don't manually add "---". This breaks a lot of workflow scripts.
"Patchwork" missed your Signed-off, for example!

> Changes in v2:
>     - pass flags with ->driver_data
>     - unmask interrupt right after masking

This paragraph...

> 
> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
> ---

... needs to go here.

However, I fixed it this time and applied to for-current, thanks!

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] I2C: designware: fix IO timeout issue for AMD  controller Wolfram Sang <wsa@the-dreams.de> - 2015-12-12 18:10 +0100
  RE: [PATCH v2] I2C: designware: fix IO timeout issue for AMD  controller "Yu, Xiangliang" <Xiangliang.Yu@amd.com> - 2015-12-13 13:20 +0100

csiph-web