Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var
Date	2015-12-12 11:20 +0100
Message-ID	<qEPrs-PW-3@gated-at.bofh.it> (permalink)
References	<qD3Id-4T1-9@gated-at.bofh.it> <qDFku-3Y0-9@gated-at.bofh.it> <qEO2m-8hM-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > > This patch does the following:
> > > * changed the complicated if statements to simple case statements
> > > * in case of E_DEFAULT, no need to return error as ERESTART,
> > > because this is the user asked for. Hence function should return success.
> > > * ret variable is 0 always, hence removed it.
> > > * removed one ternary operator, as it was always returning the status value only,
> > > and hence removed the status variable too
> > 
> > That becomes 4 different changes. Please break them into separate
> > patches.
> 
> It's cleaning up one function so you could argue that it's just one
> thing.

Then maybe that should have been mentioned in the commit message along
with mentioning point wise the different changes made.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var Saurabh Sengar <saurabh.truth@gmail.com> - 2015-12-07 14:10 +0100
  Re: [PATCH] Staging: speakup: varhandlers: cleanup of function  spk_get_punc_var Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-09 06:20 +0100
    Re: [PATCH] Staging: speakup: varhandlers: cleanup of function  spk_get_punc_var Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-12 09:50 +0100
      Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var Saurabh Sengar <saurabh.truth@gmail.com> - 2015-12-12 10:00 +0100
      Re: [PATCH] Staging: speakup: varhandlers: cleanup of function  spk_get_punc_var Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-12 11:20 +0100
        Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var Saurabh Sengar <saurabh.truth@gmail.com> - 2015-12-12 13:00 +0100

csiph-web