Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290101

[RFC 3/3] irq: Privatize irq_common_data::state_use_accessors

Show all headers | View raw

According to Peter Zijlstra, irq_common_data::state_use_accessors is not
designed for public use. Therefore make it private so that people who
write code accessing it directly will get blamed by sparse.

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
 include/linux/irq.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 3c1c967..0b8f273 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -137,7 +137,7 @@ struct irq_domain;
  * @msi_desc:		MSI descriptor
  */
 struct irq_common_data {
-	unsigned int		state_use_accessors;
+	unsigned int		__private state_use_accessors;
 #ifdef CONFIG_NUMA
 	unsigned int		node;
 #endif
@@ -208,7 +208,7 @@ enum {
 	IRQD_FORWARDED_TO_VCPU		= (1 << 20),
 };
 
-#define __irqd_to_state(d)		((d)->common->state_use_accessors)
+#define __irqd_to_state(d) ACCESS_PRIVATE((d)->common, state_use_accessors)
 
 static inline bool irqd_is_setaffinity_pending(struct irq_data *d)
 {
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/3] sparse: Introduce __private to privatize members of structs Boqun Feng <boqun.feng@gmail.com> - 2015-12-12 04:00 +0100
  [RFC 1/3] sparse: Add __private to privatize members of structs Boqun Feng <boqun.feng@gmail.com> - 2015-12-12 04:00 +0100
  [RFC 2/3] RCU: Privatize rcu_node::lock Boqun Feng <boqun.feng@gmail.com> - 2015-12-12 04:00 +0100
  [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Boqun Feng <boqun.feng@gmail.com> - 2015-12-12 04:00 +0100
    Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Peter Zijlstra <peterz@infradead.org> - 2015-12-14 11:00 +0100
      Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Thomas Gleixner <tglx@linutronix.de> - 2015-12-14 11:10 +0100
        Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Boqun Feng <boqun.feng@gmail.com> - 2015-12-14 13:10 +0100
          Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Thomas Gleixner <tglx@linutronix.de> - 2015-12-14 17:10 +0100
            Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 02:00 +0100

csiph-web