Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289971

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

From "H. Peter Anvin" <hpa@zytor.com>
Newsgroups linux.kernel
Subject Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance
Date 2015-12-11 23:40 +0100
Message-ID <qEEw1-261-9@gated-at.bofh.it> (permalink)
References (12 earlier) <qEDJE-1yy-5@gated-at.bofh.it> <qEEcG-1XA-19@gated-at.bofh.it> <qEEcG-1XA-21@gated-at.bofh.it> <qEEcG-1XA-17@gated-at.bofh.it> <qEEml-21X-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 12/11/15 14:24, Andy Lutomirski wrote:
> 
> To do the whole shebang at once:
> 
> ioctl(ptmx_fd, TIOCWHATEVER, fd_to_devpts_mount);
> 
> returns the slave number if fd_to_devpts_mount points to the right
> place or an error if not.
> 
> ptsname(fd) logically does:
> 
> fd_to_devpts_mount = open("/dev/pts", O_RDONLY | O_DIRECTORY);
> int n = ioctl(fd, TIOCWHATEVER, fd_to_devpts_mount);
> close(fd_to_devpts_mount);
> if (n < 0)
>   return some error;
> return "/dev/pts/" + n;
> 
> I think that all kinds of variants are possible.
> 

If we're going to invent new names, any reason to not simply have
TIOCPTSNAME, since we can find the pts inode from the ptm fd, and then
walk the dentry tree (returning error if unreachable)?

Or does that open up entirely new issues?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-11 20:50 +0100
  Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-11 22:00 +0100
    Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-11 22:20 +0100
  Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Al Viro <viro@ZenIV.linux.org.uk> - 2015-12-11 22:10 +0100
    Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-11 22:30 +0100
      Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-11 22:50 +0100
        Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-11 23:20 +0100
          Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-11 23:30 +0100
            Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-11 23:40 +0100
        Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-11 23:20 +0100
          Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-11 23:50 +0100
            Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Jann Horn <jann@thejh.net> - 2015-12-12 00:00 +0100
              Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-12 00:10 +0100
                Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-12 00:20 +0100
                Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-12 00:40 +0100
              Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-12 00:10 +0100
            Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-12 00:00 +0100
            Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Andy Lutomirski <luto@amacapital.net> - 2015-12-12 00:00 +0100
        Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-11 23:20 +0100
  Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Peter Hurley <peter@hurleysoftware.com> - 2015-12-14 20:50 +0100
    Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-14 21:00 +0100
    Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-19 22:30 +0100
      Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-20 05:30 +0100
        Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance "H. Peter Anvin" <hpa@zytor.com> - 2015-12-20 05:40 +0100
          Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-20 11:00 +0100
            Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance ebiederm@xmission.com (Eric W. Biederman) - 2015-12-21 23:20 +0100
              Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-21 23:30 +0100

csiph-web