Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289956

Re: [RFC][PATCH] module: Limit line length of module prints

Show all headers | View raw

On 12/11/2015 01:39 AM, Rusty Russell wrote:
> Laura Abbott <labbott@fedoraproject.org> writes:
>> print_modules currently uses pr_cont to print all module information.
>> This has the side effect of printing lots of modules on one very long
>> line. This makes copy/pasting oopses more effort if manual wrapping is
>> required. Place a reasonable limit (80 chars) on the number of modules
>> on each line.
>>
>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>> ---
>> Does this bother anyone else or am I the only one who hates dealing
>> with the long lines of "Modules linked in"?
>
> Never bothered me, but I'm a bit odd :)  I worry more about the effect
> on machine parsing.
>

Yes, that was a concern I had as well, but the module list seems to get
wrapped eventually (although at a much longer length) so it seems like
if machine parsing can handle one wrap it can handle multiple wraps.
  
> Cheers,
> Rusty.
>

Thanks,
Laura
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] module: Limit line length of module prints Laura Abbott <labbott@fedoraproject.org> - 2015-12-11 03:00 +0100
  Re: [RFC][PATCH] module: Limit line length of module prints Rusty Russell <rusty@rustcorp.com.au> - 2015-12-11 10:50 +0100
    Re: [RFC][PATCH] module: Limit line length of module prints Laura Abbott <labbott@redhat.com> - 2015-12-11 23:30 +0100
      Re: [RFC][PATCH] module: Limit line length of module prints Rusty Russell <rusty@rustcorp.com.au> - 2015-12-14 04:30 +0100
        Re: [RFC][PATCH] module: Limit line length of module prints Laura Abbott <labbott@redhat.com> - 2015-12-15 23:50 +0100
  Re: [RFC][PATCH] module: Limit line length of module prints Laura Abbott <labbott@redhat.com> - 2015-12-11 23:30 +0100

csiph-web