Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1289881

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write
Date 2015-12-11 21:20 +0100
Message-ID <qECkx-LZ-5@gated-at.bofh.it> (permalink)
References <qEC1c-q7-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote:
> Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769,
> hence it must exit with spinlock held to avoid double unlock in dev_config.

*Ugh*

Just take that spinlock before the if (retval < 0) and don't drop it after
clear_req(), then...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write David Eccher <d.eccher@gmail.com> - 2015-12-11 21:00 +0100
  Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write Al Viro <viro@ZenIV.linux.org.uk> - 2015-12-11 21:20 +0100
    Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write David Eccher <d.eccher@gmail.com> - 2015-12-11 22:20 +0100
  Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-11 22:00 +0100

csiph-web