Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288448

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

Show all headers | View raw

On Wed, Dec 09, 2015 at 05:42:41PM +0100, Arnd Bergmann wrote:
> With the new optimized do_div() code, some versions of gcc
> produce obviously incorrect code that leads to a link error
> in iwlegacy/common.o:
> 
> drivers/built-in.o: In function `il_send_rxon_timing':
> :(.text+0xa6b4d4): undefined reference to `____ilog2_NaN'
> :(.text+0xa6b4f0): undefined reference to `__aeabi_uldivmod'
> 
> In a few thousand randconfig builds, I have seen this problem
> a couple of times in this file, but never anywhere else in the
> kernel, so we can try to work around this in the only file
> that shows the behavior, by marking the il_adjust_beacon_interval
> function as noinline, which convinces gcc to use the unoptimized
> do_div() all the time.

I don't think this is good way to "fix" the issue, but also have
nothing against to this particular change.

Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline Arnd Bergmann <arnd@arndb.de> - 2015-12-09 17:50 +0100
  Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-12-09 18:20 +0100
  Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline Stanislaw Gruszka <sgruszka@redhat.com> - 2015-12-10 12:20 +0100

csiph-web