[PATCH] regulator: pv88090: Fix irq leak

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Axel Lin <axel.lin@ingics.com>
Newsgroups	linux.kernel
Subject	[PATCH] regulator: pv88090: Fix irq leak
Date	Thu, 10 Dec 2015 11:20:01 +0100
Message-ID	<qE6ul-4PD-7@gated-at.bofh.it> (permalink)
X-Original-To	Mark Brown <broonie@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:content-type:mime-version :content-transfer-encoding; bh=x6Fi5gPTkqv3ukUaTuL9qGfkulq4XqhoNe32YEnYzDI=; b=vF9K2wqt46DAgfEmq+S30D4GVMUm1uF7BQm0BLiUYHFGzSAuiOb7Li55kwxWQUUZxZ +saSjkMHC/8lzyzP0Z6QLwFsTVIaG1aJd5W39Zz5Lyqv7skRqs3I1ua51uuHwc0q6G2a BQBwZCKoyA2f+1qLohjnduryIueYltEzekYAzORICqoXqw+HGHSdBlNmQVipCf7QZs79 GTpFM4+VoQsEEMHkNwCYkOmkiYBXCAlGEz5ni5lsr9HGZjffJCvKRjyAn70HIHujqKxB vSMA2M8bGar8PZNja6BsiZ+ukMACZXTvQ0+5AVFwWa8ecMP+Qz87femhpv/3ZLu9tjVG Q9/Q==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=x6Fi5gPTkqv3ukUaTuL9qGfkulq4XqhoNe32YEnYzDI=; b=GaVgT5pBcPd7+w2rHMTuDNE1qa+TDaVH63yenJwrIIaF4gMgdHCmj5yjpzgkmB7oWk cWzLRUkDgz8LbmTHHPFRBArWqXFEOWnK8jtg+L3bAQ3bmgHbSASjb1hzIJvW+dj41z0d kbVQrcB68YmqlX3juzg3l6wfrXhSKIOVU7uWzbwhlFBUUmeN//Xh648e2n8rqSo7SsJY dVNuGUdwR8Fh9Ym4ttUpNjQOZJVRJ2yVmJKg+cZ+VHTLO5jCKxG6VM2e2gA2MaOy2bY6 zpHfrM3IeR+VGuPAnaMw1F+G0N+JTbSS2D4mkma17E8vjZh15oK2Q+A90lQa2uTop27V bfgw==
X-Gm-Message-State	ALoCoQnOWJaTyyYu8kmnlOzm2lwEHVOvXTSQ/rApLbDO/sge9HMVXaZF7hNxKUe7nHDjpgqeVDvlAZrlsEkDqULeQnF1GLLO8A==
X-Received	by 10.66.222.202 with SMTP id qo10mr15230006pac.27.1449742323751; Thu, 10 Dec 2015 02:12:03 -0800 (PST)
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.12.11-0ubuntu3
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	James Ban <James.Ban.opensource@diasemi.com>, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 10 Dec 2015 18:11:58 +0800
X-Original-Message-ID	<1449742318.28989.0.camel@ingics.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1288429

Show key headers only | View raw

Use devm_request_threaded_irq to ensure the irq is freed when unload the
module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/pv88090-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/pv88090-regulator.c b/drivers/regulator/pv88090-regulator.c
index 3ec5f2b..2513fef 100644
--- a/drivers/regulator/pv88090-regulator.c
+++ b/drivers/regulator/pv88090-regulator.c
@@ -357,7 +357,7 @@ static int pv88090_i2c_probe(struct i2c_client *i2c,
 			return ret;
 		}
 
-		ret = request_threaded_irq(i2c->irq, NULL,
+		ret = devm_request_threaded_irq(&i2c->dev, i2c->irq, NULL,
 					pv88090_irq_handler,
 					IRQF_TRIGGER_LOW|IRQF_ONESHOT,
 					"pv88090", chip);
-- 
2.1.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] regulator: pv88090: Fix irq leak Axel Lin <axel.lin@ingics.com> - 2015-12-10 11:20 +0100

csiph-web