Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1288244
| From | Alexander Stein <alexander.stein@systec-electronic.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access |
| Date | 2015-12-10 08:20 +0100 |
| Message-ID | <qE3G9-2Ub-1@gated-at.bofh.it> (permalink) |
| References | <qE2qL-1W9-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thursday 10 December 2015 11:25:30, Bhuvanchandra DV wrote: > DSPI instances in Vybrid have a different amount of chip selects > and CTARs (Clock and transfer Attributes Register). In case of > DSPI1 we only have 2 CTAR registers and 4 CS. In present driver > implementation CTAR offset is derived from CS instance which will > lead to out of bound access if chip select instance is greater than > CTAR register instance, hence use single CTAR0 register for all CS > instances. Since we write the CTAR register anyway before each access, > there is no value in using the additional CTAR registers. Also one > should not program a value in CTAS for a CTAR register that is not > present, hence configure CTAS to use CTAR0. Shouldn't the information put into struct fsl_dspi_devtype_data how much CTAR and CS the actual implementation has available? E.g. LS1021A has 6 CS and 4 CTAR Best regards, Alexander -- ----- Please note our closure period for Christmas vacation and turn of the year We are closed from 21st December 2015 to 3rd January 2016 ----- Dipl.-Inf. Alexander Stein SYS TEC electronic GmbH alexander.stein@systec-electronic.com Legal and Commercial Address: Am Windrad 2 08468 Heinsdorfergrund Germany Office: +49 (0) 3765 38600-0 Fax: +49 (0) 3765 38600-4100 Managing Directors: Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt; Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp Commercial Registry: Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] spi-fsl-dspi: Fix CTAR Register access Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> - 2015-12-10 07:00 +0100
Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access Alexander Stein <alexander.stein@systec-electronic.com> - 2015-12-10 08:20 +0100
Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> - 2015-12-10 09:50 +0100
Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access Alexander Stein <alexander.stein@systec-electronic.com> - 2015-12-10 10:10 +0100
Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access Stefan Agner <stefan@agner.ch> - 2015-12-10 17:40 +0100
Re: [PATCH v2] spi-fsl-dspi: Fix CTAR Register access Stefan Agner <stefan@agner.ch> - 2015-12-10 17:50 +0100
csiph-web