Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286905

Re: [v9, 6/6] fsl/fman: Add FMan MAC driver

Show all headers | View raw

On Tue, 2015-12-08 at 14:18 -0600, Andy Fleming wrote:
> On Thu, Dec 3, 2015 at 1:19 AM,  <igal.liberman@freescale.com> wrote:
> > From: Igal Liberman <igal.liberman@freescale.com>
> > 
> > This patch adds the Ethernet MAC driver supporting the three
> > different types of MACs: dTSEC, tGEC and mEMAC.
> > 
> > Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
> 
> [...]
> 
> > +
> > +MODULE_LICENSE("Dual BSD/GPL");
> > +
> > +MODULE_AUTHOR("Emil Medve <Emilian.Medve@Freescale.com>");
> 
> I imagine this email address doesn't exist anymore, or won't soon.
> This is also an issue in the ethernet driver (with my old address).
> I'm not sure what the right approach is, but we shouldn't be putting
> obsolete email addresses in the kernel.

I don't think a MODULE_AUTHOR tag makes sense for drivers like this that had a
lot of people work on them.  git history is better for giving credit in such
cases.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [v9, 6/6] fsl/fman: Add FMan MAC driver Andy Fleming <afleming@gmail.com> - 2015-12-08 21:20 +0100
  Re: [v9, 6/6] fsl/fman: Add FMan MAC driver Scott Wood <scottwood@freescale.com> - 2015-12-08 23:50 +0100
    Re: [v9, 6/6] fsl/fman: Add FMan MAC driver David Miller <davem@davemloft.net> - 2015-12-09 03:20 +0100
      RE: [v9, 6/6] fsl/fman: Add FMan MAC driver Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-12-09 11:20 +0100

csiph-web