Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286899

Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing

Show all headers | View raw

On 12/8/2015 1:34 PM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 08:53:53 santosh shilimkar wrote:
>> On 12/8/2015 7:30 AM, Arnd Bergmann wrote:
>>> The knav_qmss driver is currently broken when CONFIG_LPAE is
>>> set, which is a bit surprising because I'd expect that any serious
>>> users of this platforms would have more than 2GB of RAM and require
>>> LPAE.
>>>
>> Well it has been working with LPAE enable always. The production
>> systems do but IIRC, some of the Eval board were still build with
>> just 2 GB memory.
>
> Maybe that just means that the debug code is never used and we can remove
> all the dev_dbg instead? That might actually be nicer as it would reduce
> the amount of code in your driver (slightly).
>
It was added in intention so that it is useful. I agree if it is not
used or useful, we should remove it.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] soc: TI knav_qmss: fix dma_addr_t printing Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:40 +0100
  Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-12-08 18:00 +0100
    Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing Arnd Bergmann <arnd@arndb.de> - 2015-12-08 22:40 +0100
      Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-12-08 23:30 +0100

csiph-web