Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286706

Re: [PATCH] vhost: vsock: select CONFIG_VHOST

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 8 Dec 2015 18:09:44 +0200

> On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote:
>> When building the new vsock code without vhost, we get a build error:
>> 
>> drivers/built-in.o: In function `vhost_vsock_flush':
>> :(.text+0x24d29c): undefined reference to `vhost_poll_flush'
>> 
>> This adds an explicit 'select' like we have for the other vhost
>> drivers.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> This will need to be done eventually, so
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
> but I really think the right thing for now is to revert current vsock
> code, or disable building it unconditionally.  Stefan, could you please
> send a patch like this?

I'm waiting for the full single revert patch and will apply it as
soon as I receive it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] vhost: vsock: select CONFIG_VHOST Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:50 +0100
  Re: [PATCH] vhost: vsock: select CONFIG_VHOST "Michael S. Tsirkin" <mst@redhat.com> - 2015-12-08 17:10 +0100
    Re: [PATCH] vhost: vsock: select CONFIG_VHOST David Miller <davem@davemloft.net> - 2015-12-08 18:20 +0100

csiph-web