Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1286571

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

From Felipe Balbi <balbi@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case
Date 2015-12-08 16:20 +0100
Message-ID <qDsdz-41I-3@gated-at.bofh.it> (permalink)
References (7 earlier) <qDmBb-nT-1@gated-at.bofh.it> <qDrrc-3vd-21@gated-at.bofh.it> <qDrAR-3yq-15@gated-at.bofh.it> <qDrAR-3yq-13@gated-at.bofh.it> <qDrKy-3Cl-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi,

Bin Liu <b-liu@ti.com> writes:
>>>>> "This bit should be set high prior to setting bit 0 and cleared after bit 0
>>>>> is cleared."
>>>>>
>>>>> and on the other side:
>>>>> "Both the soft_reset and soft_reset_isolation bits should be asserted
>>>>> simultaneously."
>>>>>
>>>>> The hang you saw could be explained by the following:
>>>>> "Setting only the soft_reset_isolation bit will cause all USB0 output
>>>>> signals to go to a known constant value via multiplexers.
>>>>> This will
>>>>> prevent future access to USB0."  page 2567
>>>>
>>>> good catch. Setting them together makes the hang go away.
>>>>
>>>> I still have the other problem, which is legacy IRQ reporting mode not
>>>> really working.
>>>>
>>>
>>> I never tried to change the IRQ mapping. The 8 MUSB interrupt will be
>>> the same no matter where they are reported from. What do you expect when
>>> switch to the MUSB IRQ reporting mode?
>>
>> read events from MUSB's registers instead of TI's :-) so, MUSB_INTRUSB,
>> MUSB_INTRRX and MUSB_INTRTX.
>>
> I meant you expect to see any different event when switch to MUSB IRQ 
> mode? The TI wrapper just reports the same 8 interrupt events. I don't 
> think you would get any difference.

still valid to make sure ;-)

> BTY, I think I miss some context here. This Gregory's patch is trying to 
> fix the OTG state machine problem in musb_dsps, which is replicated with 
> a cable without a device connected. But it also mentions about 
> non-compliant MSC devices. How are the thumb drives related to this OTG 
> state issue?

the problem seems to be caused by the missing disconnect IRQ. Not really
missing, but taking seconds to trigger.

-- 
balbi

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-12-07 11:00 +0100
  Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Felipe Balbi <balbi@ti.com> - 2015-12-07 20:30 +0100
    Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-12-08 10:20 +0100
      Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Felipe Balbi <balbi@ti.com> - 2015-12-08 15:30 +0100
        Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Felipe Balbi <balbi@ti.com> - 2015-12-08 15:40 +0100
          Re: [PATCH] usb: musb: dsps: handle the  otg_state_a_wait_vrise_timeout case Bin Liu <b-liu@ti.com> - 2015-12-08 15:50 +0100
            Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case Felipe Balbi <balbi@ti.com> - 2015-12-08 16:20 +0100
        Re: [PATCH] usb: musb: dsps: handle the  otg_state_a_wait_vrise_timeout case Bin Liu <b-liu@ti.com> - 2015-12-08 15:40 +0100

csiph-web