[PATCH] net: fsl: avoid 64-bit warning on pq_mdio

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] net: fsl: avoid 64-bit warning on pq_mdio
Date	Tue, 08 Dec 2015 16:20:02 +0100
Message-ID	<qDsdA-41I-9@gated-at.bofh.it> (permalink)
X-Original-To	"David S. Miller" <davem@davemloft.net>
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:dDRdFdmwN3WLI9YNaKSnWSEKhsKuxNcA1wNpJve5kengU6ESY8t YY/CHUqbj3HIC1MUfTa1CIPyTU/LPw+gfc0BJBVeEgNNkeEjqyT8K29nqiiwqQEh8a19tHE sRnbtLIZzJ1oQfq8+G/sS50ca5FVOsXN0lrEd0fdRBJc4p28PpcgTo2G75AONrI6qapBPz9 B8iEFqVvIBeQu0x9zD9ew==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:b992WwMK1/E=:l2t4CUmZridGBayh+1fGke Hr8rXiN8PS8L0fOPqP2lJKn/pNQahRuBKbUQOGMRQRP0rv0AXVnqH1okVvT04ZR0j+tKeQGPW fpNo7h1uG1vY6mUaPzgIe3ED6orHLLQ+W5fiM7NQUOzXBcg38GXVDFleqbre8FghYHLePzDHC LbJcq0lpkZssuS7NWWVZtmaxxz/bhxK4eoBUtkJ1t9OptHbuKyfcoDP5shF9+k0xg7ckbPahU +HQwKElMcSg0LfeKmFg6yr45R+Sot8aGFc2Q7cHJ97geNFQ5P88WS8SLBeUDij8mK7QBDgD4W qXJL8sUd3Nhr9bxBemie3MzfbeXR1ks/ws8ipOdnKIXyqxYpM16tLQB09CRL+XrSiqlX6Z3DB lhjFcA5tDJOFewxgyhvFvNez8auf7DxjtV86ffXlFFXxIgSBKm7bh3CniiqjUjxkVyVukSNSN ZzRNDM1hBRqKdiAXLSc2NwpBViFYjB0hkO7O9SBgB0KHrfgiRbjEx1aNHzHaBZEL0WQ5Zinte EOy3kmiiAMwTQmrp1qeJALqqO0P7nR8WXvnF9jC8HIg1EIkMtoLA9qdYOlsf5mrpmB17a4Gv5 pcTjCzgaQOmGxeWuq8Mf9r5ZhkcL3rzZ+jnYtBEPEMW3PDZem1hOiasih+AdUUY01nCC22LVP KiVMUvyhH/sIXM/zKL0r1/ZcHVKU7RzGW5L5z9FPU7wHAv0gdOtq3qFdFcEOQiAMcbZAOANe4 as5Cj4879V4FEdUt
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Gerlando Falauto <gerlando.falauto@keymile.com>, netdev@vger.kernel.org, Shaohui Xie <Shaohui.Xie@freescale.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Tue, 08 Dec 2015 16:17:29 +0100
X-Original-Message-ID	<2847304.4thPqtFFJS@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1286573

Show key headers only | View raw

The pq_mdio driver can now be built for ARM64, where we get a format
string warning:

drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_probe':
drivers/net/ethernet/freescale/fsl_pq_mdio.c:467:25: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat=]

The argument is an implicit ptrdiff_t from the subtraction of two pointers,
so we should use the %z format string modifier to make this work on 64-bit
architectures.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fe761bcb9046 ("net: fsl: expands dependencies of NET_VENDOR_FREESCALE")
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 55c36230e176..40071dad1c57 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -464,7 +464,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 			 * address). Print error message but continue anyway.
 			 */
 			if ((void *)tbipa > priv->map + resource_size(&res) - 4)
-				dev_err(&pdev->dev, "invalid register map (should be at least 0x%04x to contain TBI address)\n",
+				dev_err(&pdev->dev, "invalid register map (should be at least 0x%04zx to contain TBI address)\n",
 					((void *)tbipa - priv->map) + 4);
 
 			iowrite32be(be32_to_cpup(prop), tbipa);
-- 
2.1.0.rc2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: fsl: avoid 64-bit warning on pq_mdio Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:20 +0100
  Re: [PATCH] net: fsl: avoid 64-bit warning on pq_mdio David Miller <davem@davemloft.net> - 2015-12-09 05:00 +0100

csiph-web