Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1286634
| From | Damien Horsley <Damien.Horsley@imgtec.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC |
| Date | 2015-12-08 17:10 +0100 |
| Message-ID | <qDsZZ-4yl-35@gated-at.bofh.it> (permalink) |
| References | <qyHGh-6l3-3@gated-at.bofh.it> <qyHGh-6l3-5@gated-at.bofh.it> <qyHGh-6l3-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 25/11/15 12:47, Mark Brown wrote: > On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote: > >> + /* The mute state as set by alsa using the digital_mute callback */ >> + bool alsa_mute_state; >> + /* The mute state as set by the userspace mute control */ >> + bool control_mute_state; >> + /* The actual mute state is equal to an OR of the above */ > > Does the device *need* the digital mute to avoid noise? If there's no > strong need for it then just don't bother which simplifies the code a > lot. > > Otherwise this looks good. > It does not seem to make a difference. I will remove and repost. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC Damien Horsley <Damien.Horsley@imgtec.com> - 2015-12-08 17:10 +0100
csiph-web