Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps
Date	2015-12-08 16:10 +0100
Message-ID	<qDs3V-3Yk-19@gated-at.bofh.it> (permalink)
References	<qD1Gr-3oq-37@gated-at.bofh.it> <qDqYa-348-13@gated-at.bofh.it> <qDqYb-348-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 08 December 2015 14:52:05 Neil Armstrong wrote:
> Add 1:1 mapping of software defines caps parsing from DT in case the
> generic macb compatible form is used.
> These properties will provide support for futures implementations
> only defined from DT without need to update the driver code to support
> new variants.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> 

Translating the Linux implementation specific configuration into
DT properties directly is usually not the best way.

Could we instead have a lookup table by compatible string to set the
flags? It seems that there are lots of different flags but only a
couple of different users of this IP block. Also, the fact that
you are now adding yet another quirk tells me that the set you
define today is unlikely to cover all the future requirements.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net 0/2] Add a property to disable MACB USRIO register Neil Armstrong <narmstrong@baylibre.com> - 2015-12-07 12:00 +0100
  [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms Neil Armstrong <narmstrong@baylibre.com> - 2015-12-07 12:10 +0100
    Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on  some platforms David Miller <davem@davemloft.net> - 2015-12-07 20:10 +0100
    Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on  some platforms Josh Cartwright <joshc@ni.com> - 2015-12-07 20:40 +0100
      Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on  some platforms Neil Armstrong <narmstrong@baylibre.com> - 2015-12-08 10:30 +0100
        Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on  some platforms Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-12-08 10:40 +0100
  [PATCH v2 net-next 3/3] bindings: ethernet: macb: Add optional caps properties Neil Armstrong <narmstrong@baylibre.com> - 2015-12-08 15:00 +0100
    Re: [PATCH v2 net-next 3/3] bindings: ethernet: macb: Add optional  caps properties Rob Herring <robh@kernel.org> - 2015-12-09 05:00 +0100
  [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps Neil Armstrong <narmstrong@baylibre.com> - 2015-12-08 15:00 +0100
    Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:10 +0100
      Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback  to read DT provided caps Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-12-08 17:30 +0100
  [PATCH v2 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps Neil Armstrong <narmstrong@baylibre.com> - 2015-12-08 15:00 +0100
  [PATCH v2 net-next 0/3] Add new capability and parse from DT Neil Armstrong <narmstrong@baylibre.com> - 2015-12-08 15:00 +0100

csiph-web