Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286552

Re: [PATCH] fix inverted test in __skb_recv_datagram

Show all headers | View raw

David Miller <davem@davemloft.net> writes:
> From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
> Date: Mon, 07 Dec 2015 23:30:58 +0000
>
>> As the kernel generally uses negated error numbers, *err needs to be
>> compared with -EAGAIN (d'oh).
>> 
>> Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com>
>> Fixes: ea3793ee29d3
>
> Improperly formatted Fixes: tag, you must also include the commit
> header line, in parenthesis and double quotes, after the SHA_ID.
>
> Futhermore this is the wrong SHA_ID.

https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=ea3793ee29d3

displays the commit I was referring to, namely, the one containing this

+ timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
+
+ do {
+ skb = __skb_try_recv_datagram(sk, flags, peeked, off, err,
+ &last);
+ if (skb)
+ return skb;
+
+ if (*err != EAGAIN)
+ break;
+ } while (timeo &&
+ !__skb_wait_for_more_packets(sk, err, &timeo, last));

which added the inverted test, IOW, if this is the wrong hash, I have no
idea what the right one could be. I'll resubmit this with the 'one line
summary' added. After noticing the issue around 23:10 UK time yesterday,
I was in a bit of a hurry and stopped reading the 'Fixes' text in
SubmittingPatches after the "with the first 12 characters".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/02] core: enable more fine-grained datagram reception control Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-06 22:20 +0100
  Re: [PATCH 01/02] core: enable more fine-grained datagram  reception control David Miller <davem@davemloft.net> - 2015-12-07 05:40 +0100
    breaks blocking receive for other users (was: [PATCH 01/02] core: enable more fine-grained datagram reception control) Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-08 00:20 +0100
      [PATCH] fix inverted test in __skb_recv_datagram Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-08 00:40 +0100
        Re: [PATCH] fix inverted test in __skb_recv_datagram David Miller <davem@davemloft.net> - 2015-12-08 04:30 +0100
          Re: [PATCH] fix inverted test in __skb_recv_datagram Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-08 15:50 +0100
            Re: [PATCH] fix inverted test in __skb_recv_datagram David Miller <davem@davemloft.net> - 2015-12-08 17:40 +0100
          Re: [PATCH] fix inverted test in __skb_recv_datagram Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-08 15:50 +0100
            Re: [PATCH] fix inverted test in __skb_recv_datagram David Miller <davem@davemloft.net> - 2015-12-08 17:40 +0100
              Re: [PATCH] fix inverted test in __skb_recv_datagram Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2015-12-08 21:20 +0100

csiph-web