Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1286421

Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1

From Bastien Nocera <hadess@hadess.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1
Date 2015-12-08 13:20 +0100
Message-ID <qDppo-2eU-23@gated-at.bofh.it> (permalink)
References <qCYpb-1oX-3@gated-at.bofh.it> <qCYpb-1oX-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hey Priit,

On Mon, 2015-12-07 at 09:26 +0200, Priit Laes wrote:
> This patch adds Goodix GT801 2+1 touchscreen controller support.
> 
> GT801 2+1 is a 10-finger touch controller consisting of
> ARM controller interfacing two GT801 5-finger controllers.

This would implement support for the "Guitar" protocol used by a few
more variants of the GT80x devices. Can you rename the driver/docs to that effect?
<snip>
> +
> +static const struct i2c_device_id gt801x_ts_id[] = {
> +	{ "GDIX1001:00", 0 },

This clashes with the ID used in the goodix.c driver.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 Priit Laes <plaes@plaes.org> - 2015-12-07 08:30 +0100
  Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for  Goodix GT801 2+1 Bastien Nocera <hadess@hadess.net> - 2015-12-08 13:20 +0100
  Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix  GT801 2+1 Rob Herring <robh@kernel.org> - 2015-12-08 16:20 +0100

csiph-web