Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286431

Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64.

Show all headers | View raw

On Tue, Dec 08, 2015 at 03:03:03PM +0800, fu.wei@linaro.org wrote:
> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>

[...]

> +#if defined(__i386__) || defined(__x86_64__)
>  /*
>   * Check if firmware advertises firmware first mode. We need FF bit to be set
>   * along with a set of MC banks which work in FF mode.
>   */
>  static int __init hest_parse_cmc(struct acpi_hest_header *hest_hdr, void *data)
>  {
> -	return arch_apei_enable_cmcff(hest_hdr, data);
> +	if (!acpi_disable_cmcff)

Why do not you define the flag above in this file (move it out of x86 -
that's what I was aiming at in my previous reply) and remove this ifdeffery
altogether (First firmware handling could apply to arm64 too according to
specs and ACPI on arm64 guidelines) ?

arch_apei_enable_cmcff() is a weak function that does nothing on arm64
and if we need to add an implementation we can do it later.

Thanks,
Lorenzo

> +		return !arch_apei_enable_cmcff(hest_hdr, data);
> +
> +	return 0;
>  }
>  
> +static inline int __init hest_ia_init(void)
> +{
> +	return apei_hest_parse(hest_parse_cmc, NULL);
> +}
> +#else
> +static inline int __init hest_ia_init(void) { return 0; }
> +#endif
> +
>  struct ghes_arr {
>  	struct platform_device **ghes_devs;
>  	unsigned int count;
> @@ -232,8 +244,9 @@ void __init acpi_hest_init(void)
>  		goto err;
>  	}
>  
> -	if (!acpi_disable_cmcff)
> -		apei_hest_parse(hest_parse_cmc, NULL);
> +	rc = hest_ia_init();
> +	if (rc)
> +		goto err;
>  
>  	if (!ghes_disable) {
>  		rc = apei_hest_parse(hest_parse_ghes_count, &ghes_count);
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. fu.wei@linaro.org - 2015-12-08 08:10 +0100
  Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Hanjun Guo <hanjun.guo@linaro.org> - 2015-12-08 12:30 +0100
    Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2015-12-08 13:50 +0100
  Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-12-08 13:40 +0100
    Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Hanjun Guo <hanjun.guo@linaro.org> - 2015-12-08 14:00 +0100
      Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2015-12-08 14:10 +0100
        Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-12-08 15:10 +0100
          Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2015-12-09 04:30 +0100
            Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2015-12-10 03:10 +0100
              Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Will Deacon <will.deacon@arm.com> - 2015-12-10 12:10 +0100
  Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-12-08 17:00 +0100
    Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2015-12-09 04:10 +0100

csiph-web