RE: [v9, 3/6] fsl/fman: Add FMan MAC support

From	Liberman Igal <Igal.Liberman@freescale.com>
Newsgroups	linux.kernel
Subject	RE: [v9, 3/6] fsl/fman: Add FMan MAC support
Date	2015-12-08 12:30 +0100
Message-ID	<qDoD0-1Hi-33@gated-at.bofh.it> (permalink)
References	<qBIFQ-1rh-17@gated-at.bofh.it> <qBIFQ-1rh-19@gated-at.bofh.it> <qBIFQ-1rh-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


Regards,
Igal Liberman

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Thursday, December 03, 2015 10:24 PM
> To: Liberman Igal-B31950 <Igal.Liberman@freescale.com>
> Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Wood Scott-B07421 <scottwood@freescale.com>;
> Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>;
> pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com;
> stephen@networkplumber.org
> Subject: Re: [v9, 3/6] fsl/fman: Add FMan MAC support
> 
> From: <igal.liberman@freescale.com>
> Date: Thu, 3 Dec 2015 09:19:14 +0200
> 
> > +static u32 crc_table[256] = {
> 
> No way.
> 
> We have every conceivable implementation of CRC calculations in the kernel
> already.  Use them.

OK, I will remove the private implementation of CRC calculation in the next submission. Thank you.

Igal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [v9, 3/6] fsl/fman: Add FMan MAC support David Miller <davem@davemloft.net> - 2015-12-03 21:30 +0100
  RE: [v9, 3/6] fsl/fman: Add FMan MAC support Liberman Igal <Igal.Liberman@freescale.com> - 2015-12-08 12:30 +0100

csiph-web