Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date	Tue, 08 Dec 2015 11:10:02 +0100
Message-ID	<qDnnA-TA-9@gated-at.bofh.it> (permalink)
References	<qAZz4-5UF-13@gated-at.bofh.it> <qD1ZM-3Ks-11@gated-at.bofh.it> <qD8HU-8aH-9@gated-at.bofh.it>
X-Original-To	linux-arm-kernel@lists.infradead.org
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:qu0IJ26e1Gto7hrfKWL/hdJQZ9Tz9j5g/C1SwF63zxvNIc0kVWL pMXDGCEedtJ0NmEPeZY6UaiGRVWs9mz0imMi2BegUe72D3b42oMXtvgx/HNMdScKzQC8pBv sy+Y4lSRnQ5hxbasnosI0nCX8nqBBgn752p1fmUGUA+C0xxFEl804bvYi8leu5NFgS/MWHJ +dJVpz/qKYsjCaQAXFl9Q==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:j2xmcGXOokw=:loXGz/90LeKi9P1MwtX+dK 1udUN0HwBzgUDyt6I3FTqN+db2gDub0bqqhpsD0SYGMnSZuVWUUEaeGtTPleQVruPeIlAX1XS 33lx2Y0E8zEeKZXs3Im7mQmbJCgEzhAoanrTy57FlDE/IubTfm+9x7AXJOA8kjp3fdXq9G4s+ 1Ex1pmeb+KufSw8hxii6sRazvAcDlOlb6ZdapDmBBs4NhJ+0k7fyMGk8H7jYS+m3SlPPkgxvq BRqmV+e5Yi1AIMz39ZFEq4rcPRK6+rGN2eRp/uriCTeOtgjG2fEfw2oZAuYXxfrm27z4uokHe Dg7eAC+gWzH29BCHPYzWN8lYhQ417IRq9srtu5JRw7YoJYc48wx9Ve+qWA+sZ+5hI56hUs4gQ +bb1Fo+c3Mv/095/xBjXM00Lyo0RGQ8bDJNZ0kE+LdG5xCo7hEa2dhdCjIOx474egNIG1hpT1 lPwFtKX7NWPw07SyMdCIT5Htdu6K3pMWupPTmGDPxCMjTvKIZ6QNRqjY7hRFaaQ6kQdQwDKON soDnWIrQbjepd1xf1LR/Sc/I+ICQMXIE22hbLKqNEWWDRaFb0RUOttNyyXZSd9LMJmwVUtT7m K+tmtdjXHKyS3KmhBcz97s3Yb4EB87OccvnokB/RzTMAgQqwWHPGoPA34q8bj0Gor3SQxarEs YPX4Rc8gSNj+xWZGb1Iu34VXsk0ZQ7rF+WdE9r6n3UNLpFpUtsx8Q0RXeodQcMcYhYHBJaPtn qNdHhCQHns6Uxsvq
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	Daniel Cashman <dcashman@android.com>, Jon Hunter <jonathanh@nvidia.com>, linux-doc@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-mm@kvack.org, hpa@zytor.com, mingo@kernel.org, aarcange@redhat.com, linux@arm.linux.org.uk, kirill.shutemov@linux.intel.com, corbet@lwn.net, xypron.glpk@gmx.de, x86@kernel.org, hecmargi@upv.es, mgorman@suse.de, rientjes@google.com, bp@suse.de, nnk@google.com, dzickus@redhat.com, keescook@chromium.org, jpoimboe@redhat.com, tglx@linutronix.de, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, salyzyn@android.com, ebiederm@xmission.com, jeffv@google.com, n-horiguchi@ah.jp.nec.com, dcashman@google.com
X-Original-Date	Tue, 08 Dec 2015 11:03:51 +0100
X-Original-Message-ID	<7610963.Sys3aageLY@wuerfel>
X-Original-References	<1449000658-11475-1-git-send-email-dcashman@android.com> <1720878.JdEcLd8bhL@wuerfel> <5665CF5A.1090207@android.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1286365

Show key headers only | View raw

On Monday 07 December 2015 10:26:34 Daniel Cashman wrote:
> > Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
> > and change this code to use
> > 
> >       if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))
> > 
> That would result in "undefined reference to mmap_rnd_compat_bits" in
> the not-defined case, no?

No. The compiler eliminates all code paths that it knows are unused.
The IS_ENABLED() macro is designed to let the compiler figure this out.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Daniel Cashman <dcashman@android.com> - 2015-12-01 21:20 +0100
  [PATCH v5 4/4] x86: mm: support ARCH_MMAP_RND_BITS. Daniel Cashman <dcashman@android.com> - 2015-12-01 21:20 +0100
  Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Will Deacon <will.deacon@arm.com> - 2015-12-03 13:20 +0100
    Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Daniel Cashman <dcashman@android.com> - 2015-12-03 17:20 +0100
  Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Jon Hunter <jonathanh@nvidia.com> - 2015-12-07 11:30 +0100
    Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Arnd Bergmann <arnd@arndb.de> - 2015-12-07 12:20 +0100
      Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Daniel Cashman <dcashman@android.com> - 2015-12-07 19:30 +0100
        Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Arnd Bergmann <arnd@arndb.de> - 2015-12-08 11:10 +0100

csiph-web