Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32

From	Mel Gorman <mgorman@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32
Date	2015-12-08 10:50 +0100
Message-ID	<qDn4e-xE-3@gated-at.bofh.it> (permalink)
References	<qBtx7-8sd-1@gated-at.bofh.it> <qDeWZ-3Wh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 07, 2015 at 05:00:41PM -0800, Andrew Morton wrote:
> On Thu,  3 Dec 2015 13:11:40 +0900 Joonsoo Kim <js1304@gmail.com> wrote:
> 
> > Until now, COMPACT_CLUSTER_MAX is defined as SWAP_CLUSTER_MAX.
> > Commit ("mm: increase SWAP_CLUSTER_MAX to batch TLB flushes")
> > changes SWAP_CLUSTER_MAX from 32 to 256 to improve tlb flush performance
> > so COMPACT_CLUSTER_MAX is also changed to 256.
> 
> "mm: increase SWAP_CLUSTER_MAX to batch TLB flushes" has been in limbo
> for quite a while.  Because it has been unclear whether the patch's
> benefits exceed its costs+risks.
> 
> We should make a decision here - either do the appropriate testing or
> drop the patch.
> 

At this point, drop it. The benefits that apply to some corner cases are
marginal but the concerns about potentially isolating and reclaiming too
much persist.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32 Joonsoo Kim <js1304@gmail.com> - 2015-12-03 05:20 +0100
  Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32 Andrew Morton <akpm@linux-foundation.org> - 2015-12-08 02:10 +0100
    Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32 Mel Gorman <mgorman@suse.de> - 2015-12-08 10:50 +0100

csiph-web