Re: [PATCH 0/7] perf stat: Change event enable code

From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/7] perf stat: Change event enable code
Date	2015-12-08 08:40 +0100
Message-ID	<qDl2q-7Kn-9@gated-at.bofh.it> (permalink)
References	<qBy3L-2WY-5@gated-at.bofh.it> <qDbcJ-1od-9@gated-at.bofh.it>
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw

On 07/12/15 23:09, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 03, 2015 at 10:06:39AM +0100, Jiri Olsa escreveu:
>> hi,
>> while testing ftrace:function event I noticed we create
>> stat counters as enabled (except for enable_on_exec couters).
>>
>> This way we count also filter setup and other config code
>> which might be crucial for some events.
>>
>> Posponing the events enable once everything is ready.
>>
>> The last patch is RFC as I wasn't sure there's some hidden
>> catch about perf_evlist__(enable|disable)_event functions
>> I missed.. Adrian?
> 
> They look the same, Adrian?
> 
> Applied the first 6, will give some more time to Adrian to chime in.

Looks like there might already be a problem using evsel->threads instead of
evlist->threads with the logic relating to evsel->system_wide getting lost -
but that happened already in "perf evlist: Factor
perf_evlist__(enable|disable) functions".  Probably the threads should not
be propagated in that case, but it needs more investigation.  I will try to
look at it today.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/7] perf stat: Change event enable code Jiri Olsa <jolsa@kernel.org> - 2015-12-03 10:20 +0100
  [PATCH 3/7] perf tools: Factor perf_evlist__(enable|disable) functions Jiri Olsa <jolsa@kernel.org> - 2015-12-03 10:20 +0100
    [tip:perf/core] perf evlist: Factor perf_evlist__(enable|disable)   functions tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-12-08 05:40 +0100
  Re: [PATCH 0/7] perf stat: Change event enable code Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-07 22:10 +0100
    Re: [PATCH 0/7] perf stat: Change event enable code Adrian Hunter <adrian.hunter@intel.com> - 2015-12-08 08:40 +0100
      Re: [PATCH 0/7] perf stat: Change event enable code Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-08 15:00 +0100
        Re: [PATCH 0/7] perf stat: Change event enable code Adrian Hunter <adrian.hunter@intel.com> - 2015-12-09 14:50 +0100
          Re: [PATCH 0/7] perf stat: Change event enable code Adrian Hunter <adrian.hunter@intel.com> - 2015-12-11 13:50 +0100

csiph-web