Re: [PATCH 1/1] ACPI: Support D3 COLD device for old BIOS

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] ACPI: Support D3 COLD device for old BIOS
Date	Mon, 07 Dec 2015 23:20:03 +0100
Message-ID	<qDciv-2cp-35@gated-at.bofh.it> (permalink)
References	<qDciv-2cp-37@gated-at.bofh.it>
X-Original-To	Ken Xue <ken.xue@amd.com>
User-Agent	KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="utf-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, SPG_Linux_Kernel@amd.com, mika.westerberg@linux.intel.com, Andy Shevchenko <andy.shevchenko@gmail.com>, Ivan.Zheng@amd.com, Alex.Chuang@amd.com
X-Original-Date	Mon, 07 Dec 2015 23:48:56 +0100
X-Original-Message-ID	<3822904.Z6rtg8lMJ5@vostro.rjw.lan>
X-Original-References	<1449463473.2175.13.camel@kxue-X58A-UD3R>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1286017

Show key headers only | View raw

On Monday, December 07, 2015 12:44:33 PM Ken Xue wrote:
> D3cold is only regarded as valid if the "_PR3" object is present
> for the given device after the commit <20dacb71ad28>
> (ACPI/PM: Reworkdevice power management to follow ACPI 6).
> 
> But some old BIOS only defined "_PS3" for the D3COLD device.
> And old kernel also believes the device has "_PS3" is a
> D3COLD device.
> 
> So, add some logics for supporting D3 COLD device for old BIOS
> which is compatible with earlier ACPI spec.
> 
> Signed-off-by: Ken Xue <Ken.Xue@amd.com>
> Reported-and-tested-by: Gang Long <Gang.Long@amd.com>

Well, what really is the problem?

acpi_device_set_power() has a special case specifically for D3cold and
falls back to D3hot if D3cold has been requested but is not "valid".

> ---
>  drivers/acpi/scan.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 01136b8..85c16bb 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -979,7 +979,9 @@ static void acpi_bus_get_power_flags(struct acpi_device *device)
>  		acpi_bus_init_power_state(device, i);
>  
>  	INIT_LIST_HEAD(&device->power.states[ACPI_STATE_D3_COLD].resources);
> -	if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources))
> +	if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources) ||
> +		((acpi_gbl_FADT.header.revision < 6) &&
> +		device->power.states[ACPI_STATE_D3_HOT].flags.explicit_set))
>  		device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;
>  
>  	/* Set defaults for D0 and D3hot states (always valid) */
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] ACPI: Support D3 COLD device for old BIOS "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-07 23:20 +0100
  Re: [PATCH 1/1] ACPI: Support D3 COLD device for old BIOS "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-08 13:50 +0100

csiph-web