Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1285998

Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

Show all headers | View raw

Acked-by: Shannon Nelson <shannon.nelson@intel.com


On Mon, Dec 7, 2015 at 1:28 PM, David Miller <davem@davemloft.net> wrote:
> From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> Date: Mon, 7 Dec 2015 15:06:34 -0500
>
>> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
>> address in Open Firmware or IDPROM").
>>
>> As with that fix, attempt to look up the MAC address in Open Firmware
>> on systems that support it, and use IDPROM on SPARC if no OF address
>> is found.
>>
>> In the case of the i40e there is an assumption that the default mac
>> address has already been set up as the primary mac filter on probe,
>> so if this filter is obtained from the Open Firmware or IDPROM, an
>> explicit write is needed via i40e_aq_mac_address_write() and
>> i40e_aq_add_macvlan() invocation.
>>
>> The I40E_FLAG_PF_MAC flag in the platform-private i40e_pf structure
>> tracks whether a platform-specific mac address was found, in which
>> case calls to i40e_aq_mac_address_write() and i40e_aq_add_macvlan()
>> will be triggered.
>>
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
>
> This looks good to me.
>
> Once this goes in I'll add my generic MAC stuff to net-next and then
> we can convert the various Intel drivers to use it.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
==============================================

Mr. Shannon Nelson                        Network Division, Intel Corp.

Shannon.Nelson@intel.com                I don't speak for Intel

                 Parents can't afford to be squeamish
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-12-07 21:10 +0100
  Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM David Miller <davem@davemloft.net> - 2015-12-07 22:30 +0100
    Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM Shannon Nelson <shannon.nelson@intel.com> - 2015-12-07 23:10 +0100

csiph-web