Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285908
| From | Jann Horn <jann@thejh.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks |
| Date | 2015-12-07 21:40 +0100 |
| Message-ID | <qDaJI-Wm-21@gated-at.bofh.it> (permalink) |
| References | <qt215-3od-23@gated-at.bofh.it> <qCwVZ-GI-25@gated-at.bofh.it> <qDaJI-Wm-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Dec 07, 2015 at 12:32:06PM -0800, Kees Cook wrote:
> On Sat, Dec 5, 2015 at 6:04 PM, Jann Horn <jann@thejh.net> wrote:
[...]
> > - if (ptrace_may_access(task, PTRACE_MODE_READ)) {
> > + if (ptrace_may_access(task, PTRACE_MODE_READ | PTRACE_MODE_FSCREDS)) {
>
> This should maybe use the PTRACE_MODE_READ_FSCREDS macro?
Oh, yes. I don't know how I missed that. :/
> > error = ns_get_path(&ns_path, task, ns_ops);
> > if (!error)
> > nd_jump_link(&ns_path);
> > @@ -63,7 +63,7 @@ static int proc_ns_readlink(struct dentry *dentry, char __user *buffer, int bufl
> > if (!task)
> > return res;
> >
> > - if (ptrace_may_access(task, PTRACE_MODE_READ)) {
> > + if (ptrace_may_access(task, PTRACE_MODE_READ | PTRACE_MODE_FSCREDS)) {
>
> same here?
Yes.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn <jann@thejh.net> - 2015-12-06 03:10 +0100
Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Kees Cook <keescook@google.com> - 2015-12-07 21:40 +0100
Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn <jann@thejh.net> - 2015-12-07 21:40 +0100
[PATCH 1/2] security: let security modules use PTRACE_MODE_* with bitmasks Jann Horn <jann@thejh.net> - 2015-12-07 22:30 +0100
Re: [PATCH 1/2] security: let security modules use PTRACE_MODE_* with bitmasks Kees Cook <keescook@google.com> - 2015-12-07 22:40 +0100
Re: [PATCH 1/2] security: let security modules use PTRACE_MODE_* with bitmasks Casey Schaufler <casey@schaufler-ca.com> - 2015-12-07 23:00 +0100
Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn <jann@thejh.net> - 2015-12-07 22:30 +0100
Re: [PATCH 2/2] ptrace: use fsuid, fsgid, effective creds for fs access checks Kees Cook <keescook@google.com> - 2015-12-07 22:30 +0100
[PATCH 2/2] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn <jann@thejh.net> - 2015-12-07 22:30 +0100
csiph-web