[PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options()

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options()
Date	2015-12-10 04:10 +0100
Message-ID	<qDZMe-kn-23@gated-at.bofh.it> (permalink)
References	<qDZMd-kn-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Since all of its users call before setup_browser(), there's no need to
call exit_browser() inside of the function.

Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/parse-options.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c
index d09aff983581..de3290b47db1 100644
--- a/tools/perf/util/parse-options.c
+++ b/tools/perf/util/parse-options.c
@@ -766,7 +766,6 @@ int usage_with_options_internal(const char * const *usagestr,
 void usage_with_options(const char * const *usagestr,
 			const struct option *opts)
 {
-	exit_browser(false);
 	usage_with_options_internal(usagestr, opts, 0, NULL);
 	exit(129);
 }
@@ -776,8 +775,6 @@ void usage_with_options_msg(const char * const *usagestr,
 {
 	va_list ap;
 
-	exit_browser(false);
-
 	va_start(ap, fmt);
 	strbuf_addv(&error_buf, fmt, ap);
 	va_end(ap);
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options() Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
    Re: [PATCH 5/7] perf top: Delay UI browser setup after  initialization is done Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-10 18:50 +0100
      Re: [PATCH 5/7] perf top: Delay UI browser setup after  initialization is done Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-10 19:00 +0100
        Re: [PATCH 5/7] perf top: Delay UI browser setup after  initialization is done Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-10 19:10 +0100
  [PATCH 3/7] perf kvm: Remove invocation of setup/exit_browser() Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  [PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options() Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  [PATCH 4/7] perf report: Check argument before calling setup_browser() Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  [PATCH 2/7] perf annotate: Delay UI browser setup after initialization is done Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  [PATCH 1/7] perf annotate: Check argument before calling setup_browser() Namhyung Kim <namhyung@kernel.org> - 2015-12-10 04:10 +0100
  Re: [PATCHSET 0/7] perf tools: Remove browser dependency from  usage_with_options() Josh Poimboeuf <jpoimboe@redhat.com> - 2015-12-10 16:20 +0100
    Re: [PATCHSET 0/7] perf tools: Remove browser dependency from  usage_with_options() Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-10 20:00 +0100

csiph-web