Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288098

Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk

From Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
Date 2015-12-10 02:00 +0100
Message-ID <qDXKq-7id-9@gated-at.bofh.it> (permalink)
References <qDEeK-3jw-5@gated-at.bofh.it> <qDEor-3mU-43@gated-at.bofh.it> <qDXKp-7id-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2015년 12월 10일 09:53, Krzysztof Kozlowski wrote:
> On 09.12.2015 13:07, Chanwoo Choi wrote:
>> This patch adds the DMC (Dynamic Memory Controller) bus frequency node
>> which includes the devfreq-events and regulator properties. The bus
>> frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature
>> with ondemand governor.
>>
>> The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus
>> on runtime and the buck1_reg (VDD_MIF power line) supplies the power to
>> the DMC block.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos3250-monk.dts   | 6 ++++++
>>  arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++
>>  2 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
>> index 443a35085846..d982586a6533 100644
>> --- a/arch/arm/boot/dts/exynos3250-monk.dts
>> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
>> @@ -498,6 +498,12 @@
>>  	};
>>  };
>>  
>> +&bus_dmc {
>> +	devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>> +	vdd-supply = <&buck1_reg>;
>> +	status = "okay";
>> +};
>> +
>>  &xusbxti {
>>  	clock-frequency = <24000000>;
>>  };
>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> index 3e64d5dcdd60..61477943015b 100644
>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> @@ -675,6 +675,12 @@
>>  	};
>>  };
>>  
>> +&bus_dmc {
>> +	devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>> +	vdd-supply = <&buck1_reg>;
>> +	status = "okay";
>> +};
> 
> I would prefer to put this in alphabetical order... which could be
> tricky because the nodes are not entirely sorted. Maybe after the "&adc"
> node?

OK. I'll move it.

> 
> Anyway the change looks good:
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Thanks for your review.

Regards,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency driver  and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
  [PATCH v2 06/19] PM / devfreq: Add devfreq_get_devfreq_by_phandle() Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
  [PATCH v2 19/19] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
    Re: [PATCH v2 19/19] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 08:10 +0100
      Re: [PATCH v2 19/19] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 08:30 +0100
  [PATCH v2 10/19] PM / devfreq: exynos: Add the detailed correlation  between sub-blocks and power line Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
  [PATCH v2 18/19] ARM: dts: Expand the voltage range of buck1/3  regulator for exynos4412-odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
    Re: [PATCH v2 18/19] ARM: dts: Expand the voltage range of buck1/3  regulator for exynos4412-odroidu3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 08:10 +0100
      Re: [PATCH v2 18/19] ARM: dts: Expand the voltage range of buck1/3  regulator for exynos4412-odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 08:30 +0100
  [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
    Re: [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 07:50 +0100
      Re: [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-11 03:30 +0100
  [PATCH v2 08/19] PM / devfreq: exynos: Add support of bus frequency of  sub-blocks using passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
  [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for  exynos3250-rinato/monk Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
    Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for  exynos3250-rinato/monk Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 02:00 +0100
      Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for  exynos3250-rinato/monk Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 02:00 +0100
  [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for generic  exynos bus frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-09 05:20 +0100
    Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 01:40 +0100
      Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 02:00 +0100
        Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 02:30 +0100
          Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 02:40 +0100
  Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Anand Moon <linux.amoon@gmail.com> - 2015-12-09 20:10 +0100
    Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 01:20 +0100
      Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Anand Moon <linux.amoon@gmail.com> - 2015-12-10 05:20 +0100
        Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 05:30 +0100
  Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 02:00 +0100
    Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-10 02:30 +0100
      Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-10 03:20 +0100

csiph-web