Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287864

Re: [PATCH] ARM: pxa: cm-x2xx: avoid duplicate macro warnings

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> In an old commit, we worked around the duplicate definition of
> GPIO24_SSP1_SFRM in cm-x2xx.c, which includes files for both
> pxa25x and pxa27x. Apparently the problem has come back and we
> now have four additional duplicate symbols that cause warnings:
>
> In file included from /git/arm-soc/arch/arm/mach-pxa/pxa27x.h:7:0,
>                  from /git/arm-soc/arch/arm/mach-pxa/cm-x2xx.c:27:
> /git/arm-soc/arch/arm/mach-pxa/mfp-pxa27x.h:21:0: warning: "GPIO86_GPIO" redefined
>  #define GPIO86_GPIO  MFP_CFG_IN(GPIO86, AF0)
>
> This uses the same hack as before and undefines all symbols that
> are defined more than once. Fortunately, cm-x2xx does not need
> any of these.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Digging out old patches of 2012, cool.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

I suppose it's a necessary hack until I manage to kill the mfp interface in
favor of pinctrl.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: pxa: cm-x2xx: avoid duplicate macro warnings Arnd Bergmann <arnd@arndb.de> - 2015-12-09 18:00 +0100
  Re: [PATCH] ARM: pxa: cm-x2xx: avoid duplicate macro warnings Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-09 22:10 +0100

csiph-web