Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state
Date	2015-12-09 20:10 +0100
Message-ID	<qDShH-3Zb-7@gated-at.bofh.it> (permalink)
References	<qDbZ7-1Mo-3@gated-at.bofh.it> <qDbZ9-1Mo-49@gated-at.bofh.it> <qDndU-AW-13@gated-at.bofh.it> <qDS82-3Fq-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 09, 2015 at 10:56:36AM -0800, Andy Lutomirski wrote:
> That was intentional -- everything lines up with the top-level "asm(".
> checkpatch is confused because it understands "\t " at the front of a
> line but not just a space.
> 
> That being said, I could easily be convinced to switch to tabs there.

I'd say kernel coding style is tabs of 8 chars...

You could do

    asm(".pushsection .text\n\t"
	".type real_start, @function\n\t"
	".global real_start\n\t"
	"real_start:\n\t"
#ifdef __x86_64__
	"mov %rax, ax\n\t"
	"mov %rbx, bx\n\t"
	...

and align the opening "asm(" to the first tab...

Bah, whatever, I'm not that finicky to care enough.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 02/12] selftests/x86: Add check_initial_reg_state Andy Lutomirski <luto@kernel.org> - 2015-12-07 23:00 +0100
  Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Borislav Petkov <bp@alien8.de> - 2015-12-08 11:00 +0100
    Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Andy Lutomirski <luto@amacapital.net> - 2015-12-09 20:00 +0100
      Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Borislav Petkov <bp@alien8.de> - 2015-12-09 20:10 +0100
        Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Borislav Petkov <bp@alien8.de> - 2015-12-09 20:30 +0100
        Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Andy Lutomirski <luto@amacapital.net> - 2015-12-09 20:30 +0100

csiph-web