Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support
Date	2015-12-09 19:20 +0100
Message-ID	<qDRvk-3qY-5@gated-at.bofh.it> (permalink)
References	<qDC3f-1Gd-3@gated-at.bofh.it> <qDC3f-1Gd-1@gated-at.bofh.it> <qDKka-7aE-17@gated-at.bofh.it> <qDRvk-3qY-7@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On 09/12/15 18:02, Suravee Suthikulanit wrote:
> Hi Marc,
> 
> On 12/9/2015 4:38 AM, Marc Zyngier wrote:
>> On Tue, 8 Dec 2015 17:48:06 -0800
>> Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> wrote:
>>
>>> This patch introduces gicv2m_acpi_init(), which uses information
>>> in MADT GIC MSI frames structure to initialize GICv2m driver.
>>>
>>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>>> ---
>>>   drivers/irqchip/irq-gic-v2m.c   | 95 +++++++++++++++++++++++++++++++++++++++++
>>>   drivers/irqchip/irq-gic.c       |  3 ++
>>>   include/linux/irqchip/arm-gic.h |  4 ++
>>>   3 files changed, 102 insertions(+)
>>>
>>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
>>> [...]
>>> @@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
>>>
>>>   	if (to_of_node(fwnode))
>>>   		name = to_of_node(fwnode)->name;
>>> +	else
>>> +		name = irq_domain_get_irqchip_fwnode_name(fwnode);
>>
>> Don't bother with that, the name associated with the domain is
>> absolutely meaningless. You are already printing the frame address,
>> which is enough to identify it, should someone need to debug this.
>>
>> Drop the name from the previous patch as well, and that will make one
>> less difference to care about. Patch #3 can die as well.
>>
> 
> Ok. I'll just leave them blank (i.e. const char *name ="")

No, just remove name altogether. Nobody reads that anyway, and if they
want to find out, there is the address that's clear enough.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2015-12-09 02:50 +0100
  Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support Marc Zyngier <marc.zyngier@arm.com> - 2015-12-09 11:40 +0100
    Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support Marc Zyngier <marc.zyngier@arm.com> - 2015-12-09 19:20 +0100

csiph-web