Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287460

Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

Show all headers | View raw

>> +     bool                    tns_mode:1;
>> +     bool                    sqs_mode:1;

 >These little refactors are creeping in your code without even being
mentioned in the commit message, this is not good practice.
Okay, will include these in the commit message.

>IMHO. Additionally, may be turn these two flags into something like:

>enum nicvf_mode {
>        NICVF_BYPASS,
>        NICVF_TNS,
>        NICVF_SQS
>};

 >? Anyway, these modes are mutually exclusive.
VF driver always assumed to be in BYPASS mode.
Will submit a seperate cleanup patch to get rid of 'tns_mode' boolean.

Thanks,
Sunil.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware Sunil Goutham <sunil.kovvuri@gmail.com> - 2015-12-09 12:40 +0100
  RE: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware Pavel Fedin <p.fedin@samsung.com> - 2015-12-09 13:10 +0100
    Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-09 13:30 +0100
    Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware David Miller <davem@davemloft.net> - 2015-12-09 21:30 +0100

csiph-web