Re: [PATCH 1/3] ser_gigaset: fix up NULL checks

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ser_gigaset: fix up NULL checks
Date	2015-12-09 13:20 +0100
Message-ID	<qDLSV-8hh-7@gated-at.bofh.it> (permalink)
References	<qDotk-1E7-5@gated-at.bofh.it> <qDotk-1E7-21@gated-at.bofh.it> <qDwqR-6yd-3@gated-at.bofh.it> <qDyM1-89u-1@gated-at.bofh.it> <qDKtR-7f3-47@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Wed, 9 Dec 2015 11:45:57 +0100
Tilman Schmidt <tilman@imap.cc> wrote:

> Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes:
> > The right fix as far as I can see is to remove the tests although
> > WARN_ON() combined with your tty->ops change might be safer.
> 
> Feel free to submit a patch.

Will do later today. Want a patch on top of Paul's change or a single
patch including both and crediting him ?

> > tty locking reviews, but drivers/isdn and net/irda weren't traditionally
> > part of the general tty maintenance but handled separately/
> 
> Or just ignored.

Unfortunately at the time that seemed to happen a lot.

> >> test puzzle me. It's not obvious why they're needed. Ie, can the null
> >> dereferences they try to catch really happen? But I can try to figure
> >> out that in the future, if I ever feel the urge to do so. Anyhow:
> >>
> >> Acked-by: Paul Bolle <pebolle@tiscali.nl>
> > 
> > Nacked-by: Alan Cox <alan@linux.intel.com>
> 
> So you feel it's better to maintain the current inconsistent state
> created by commit f34d7a5b? Please elaborate.

No I'd rather we didn't make it look magically better then forget about
the mess in question.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/3] ser_gigaset fixes Tilman Schmidt <tilman@imap.cc> - 2015-12-08 12:20 +0100
  [PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method Tilman Schmidt <tilman@imap.cc> - 2015-12-08 12:20 +0100
    Re: [PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from  release method Paul Bolle <pebolle@tiscali.nl> - 2015-12-09 00:20 +0100
  [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure Tilman Schmidt <tilman@imap.cc> - 2015-12-08 12:20 +0100
    Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device  structure Paul Bolle <pebolle@tiscali.nl> - 2015-12-09 00:20 +0100
      Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device  structure Tilman Schmidt <tilman@imap.cc> - 2015-12-09 12:20 +0100
        Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device  structure Paul Bolle <pebolle@tiscali.nl> - 2015-12-10 12:30 +0100
        Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device  structure Peter Hurley <peter@hurleysoftware.com> - 2015-12-10 15:10 +0100
  [PATCH 1/3] ser_gigaset: fix up NULL checks Tilman Schmidt <tilman@imap.cc> - 2015-12-08 12:20 +0100
    Re: [PATCH 1/3] ser_gigaset: fix up NULL checks Paul Bolle <pebolle@tiscali.nl> - 2015-12-08 20:50 +0100
      Re: [PATCH 1/3] ser_gigaset: fix up NULL checks One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-08 23:20 +0100
        Re: [PATCH 1/3] ser_gigaset: fix up NULL checks Tilman Schmidt <tilman@imap.cc> - 2015-12-09 11:50 +0100
          Re: [PATCH 1/3] ser_gigaset: fix up NULL checks One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-09 13:20 +0100
            Re: [PATCH 1/3] ser_gigaset: fix up NULL checks Paul Bolle <pebolle@tiscali.nl> - 2015-12-09 20:20 +0100
  Re: [PATCH 0/3] ser_gigaset fixes Paul Bolle <pebolle@tiscali.nl> - 2015-12-10 12:40 +0100

csiph-web