Re: [PATCH 2/3] regmap: add 64-bit mode support

From	Xiubo Li <lixiubo@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] regmap: add 64-bit mode support
Date	2015-12-09 10:10 +0100
Message-ID	<qDIV5-6nQ-43@gated-at.bofh.it> (permalink)
References	<qBywO-38I-27@gated-at.bofh.it> <qByGt-3cm-3@gated-at.bofh.it> <qDIBH-61X-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 09/12/2015 16:45, Arnd Bergmann wrote:
> On Thursday 03 December 2015 17:31:52 Xiubo Li wrote:
>> @@ -2488,11 +2581,17 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
>>                                   * we assume that the values are native
>>                                   * endian.
>>                                   */
>> +                               u64 *u64 = val;
>>                                  u32 *u32 = val;
>>                                  u16 *u16 = val;
>>                                  u8 *u8 = val;
>>   
>>                                  switch (map->format.val_bytes) {
>> +#ifdef CONFIG_64BIT
>> +                               case 8:
>> +                                       u64[i] = ival;
>> +                                       break;
>> +#endif
>>                                  case 4:
>>                                          u32[i] = ival;
>>                                          break;
>>
> This now gives me:
>
> drivers/base/regmap/regmap.c: In function 'regmap_bulk_read':
> drivers/base/regmap/regmap.c:2584:10: warning: unused variable 'u64' [-Wunused-variable]
>       u64 *u64 = val;
>            ^
>
I will fix this.

Thanks for your catch.

BRs



> 	Arnd



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] regmap: add 64-bit mode support Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-03 10:50 +0100
  Applied "regmap: add 64-bit mode support" to the regmap tree Mark Brown <broonie@kernel.org> - 2015-12-08 20:20 +0100
  Re: [PATCH 2/3] regmap: add 64-bit mode support Arnd Bergmann <arnd@arndb.de> - 2015-12-09 09:50 +0100
    Re: [PATCH 2/3] regmap: add 64-bit mode support Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-09 10:10 +0100

csiph-web