Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286990

Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables

Show all headers | View raw

Hello Krzysztof,

On 12/08/2015 09:34 PM, Krzysztof Kozlowski wrote:
> On 08.12.2015 22:41, Javier Martinez Canillas wrote:
>> On 12/08/2015 05:13 AM, Krzysztof Kozlowski wrote:
>>>
>>> This looks like a very-non-atomic way of handling a change. You added
>>> opp tables to exynos5420 before so at that time they will be applied to
>>> Odroid XU3 family which uses different CPU order. After that you are
>>> fixing the tables to proper CPU order. Direct bisectability probably
>>> won't be an issue because all of DTS would go to separate branch... but
>>> the logic behind confuses.
>>>
>>
>> Agreed.
>>
>>> I think this should be squashed into 3/8.
>>>
>>
>> I think the patch should be split in two changes, the CPUs device nodes
>> having the wrong clock for clusters is a bug and has to be fixed in a
>> patch before adding the OPP tables and the OPP tables changes should be
>> separated and merged with patch 3/8 as you suggest.
> 
> I don't get the point about wrong clock (bug). Where is the bug? Beside
> of course what was introduced in 3/8 and it is not valid for reversed
> cluster order.
>

You are absolutely correct, for some reason I thought that the CLK_ARM_CLK
and CLK_KFC_CLK clocks were already defined in the cpu0 and cpu4 nodes from
exynos5420.dtsi and commit df09df6f9ac3 ("ARM: dts: add exynos5422-cpus.dtsi
to correct cpu order") missed that when reversing the cores for Exynos5422.

But on a second look to patch 3/8, I see that the clocks are defined in that
patch so I agree that $SUBJECT should just be squashed with 3/8 without doing
any split. Sorry for the noise.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/8] cpufreq: add generic cpufreq driver support for  Exynos542x/5800 platforms Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:20 +0100
  [PATCH v4 1/8] ARM: dts: Exynos542x/5800: add cluster regulator supply  properties Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:20 +0100
    Re: [PATCH v4 1/8] ARM: dts: Exynos542x/5800: add cluster regulator  supply properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-08 07:50 +0100
    Re: [PATCH v4 1/8] ARM: dts: Exynos542x/5800: add cluster regulator  supply properties Markus Reichl <m.reichl@fivetechno.de> - 2015-12-08 11:20 +0100
  [PATCH v4 2/8] clk: samsung: exynos5420: add cpu clock configuration  data and instantiate cpu clock Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:20 +0100
  [PATCH v4 3/8] ARM: dts: Exynos5420: add CPU OPP properties Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
    Re: [PATCH v4 3/8] ARM: dts: Exynos5420: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-08 07:30 +0100
    Re: [PATCH v4 3/8] ARM: dts: Exynos5420: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-08 08:20 +0100
  [PATCH v4 8/8] ARM: Exynos: use generic cpufreq driver for  Exynos5422/5800 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
  [PATCH v4 6/8] ARM: dts: Exynos5800: fix CPU OPP Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
    Re: [PATCH v4 6/8] ARM: dts: Exynos5800: fix CPU OPP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-08 09:10 +0100
  [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
    Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-08 09:20 +0100
      Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-08 14:50 +0100
        Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-09 01:40 +0100
          Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-09 03:20 +0100
      Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-10 17:00 +0100
  [PATCH v4 4/8] ARM: Exynos: use generic cpufreq driver for Exynos5420 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
    Re: [PATCH v4 4/8] ARM: Exynos: use generic cpufreq driver for  Exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-08 08:40 +0100
      Re: [PATCH v4 4/8] ARM: Exynos: use generic cpufreq driver for  Exynos5420 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-10 15:20 +0100
        Re: [PATCH v4 4/8] ARM: Exynos: use generic cpufreq driver for  Exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 02:20 +0100
  [PATCH v4 5/8] clk: samsung: exynos5422/5800: fix cpu clock  configuration data Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-07 19:30 +0100
  Re: [PATCH v4 0/8] cpufreq: add generic cpufreq driver support for  Exynos542x/5800 platforms Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-08 07:20 +0100
    Re: [PATCH v4 0/8] cpufreq: add generic cpufreq driver support for  Exynos542x/5800 platforms Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-08 07:30 +0100
  Re: [PATCH v4 0/8] cpufreq: add generic cpufreq driver support for  Exynos542x/5800 platforms Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-09 14:20 +0100

csiph-web