Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287015

Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device

Show key headers only | View raw

On 08-12-15, 14:32, Lee Jones wrote:
> +/**
> + * SMP Operations
> + */

Why do you need a documentation style comment here?

>  static void write_pen_release(int val)
>  {
>  	pen_release = val;
> @@ -161,3 +166,11 @@ struct smp_operations __initdata sti_smp_ops = {
>  	.smp_secondary_init	= sti_secondary_init,
>  	.smp_boot_secondary	= sti_boot_secondary,
>  };
> +
> +/**
> + * CPUFreq Registration
> + */

Here too.

> +void init_cpufreq(void)
> +{
> +	platform_device_register_simple("sti-cpufreq", -1, NULL, 0);
> +}

I don't think you need this, as you can do all the stuff you want from
the module_init() function in the driver. You just have to make sure
that your driver is only compilable and workable on the right STi platform.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 08/11] ARM: STi: Register CPUFreq device Lee Jones <lee.jones@linaro.org> - 2015-12-08 15:40 +0100
  Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-09 03:40 +0100
  Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-09 10:20 +0100
  Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device Arnd Bergmann <arnd@arndb.de> - 2015-12-09 10:20 +0100
    Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device Lee Jones <lee.jones@linaro.org> - 2015-12-09 12:30 +0100

csiph-web