Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros

From	Michal Marek <mmarek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros
Date	2015-12-07 18:20 +0100
Message-ID	<qD7Ca-7uL-11@gated-at.bofh.it> (permalink)
References	<qC0t4-4sT-23@gated-at.bofh.it> <qC0t4-4sT-21@gated-at.bofh.it> <qD6Zs-70P-17@gated-at.bofh.it> <qD7iP-78M-35@gated-at.bofh.it> <qD7su-7ro-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-12-07 18:04, Joe Perches wrote:
> On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote:
>> On 2015-12-07 17:33, David Laight wrote:
>>> From: Michal Marek
>>>> Sent: 04 December 2015 15:26
>>>> Otherwise make tags can't parse them:
>>>>
>>>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1"
>>> ...
>>>
>>> Seems to me you need to fix ctags.
>>
>> I'm sure the maintainers of ctags and etags would accept patches to
>> describe a custom context-free grammar via commandline options, but
>> until then, let's continue using the regular expressions in tags.sh and
>> remove newlines in macros that tags.sh is trying to expand.
>>
> 
> Do you have a list of the most common macros?

In practice, it's only DEFINE_PER_CPU and its sibling
DEFINE_PER_CPU_SHARED_ALIGNED, where we try to pick the second argument
to the macro and the first argument can be lengthy.


> Perhaps it'd be good to add exceptions to checkpatch
> 80 column line rules for them.

Your call. But this is a fairly rare occurrence -- 10 cases so far.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros Michal Marek <mmarek@suse.com> - 2015-12-04 16:30 +0100
  RE: [PATCH v2 8/8] treewide: Remove newlines inside  DEFINE_PER_CPU() macros David Laight <David.Laight@ACULAB.COM> - 2015-12-07 17:40 +0100
    Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Michal Marek <mmarek@suse.com> - 2015-12-07 18:00 +0100
      Re: [PATCH v2 8/8] treewide: Remove newlines inside  DEFINE_PER_CPU() macros Joe Perches <joe@perches.com> - 2015-12-07 18:10 +0100
        Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Michal Marek <mmarek@suse.com> - 2015-12-07 18:20 +0100

csiph-web