Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1285185

Re: [PATCH] usb: host: iounmap before return

Show all headers | View raw

2015-12-07 6:30 GMT-03:00 Lu Baolu <baolu.lu@linux.intel.com>:
>
>
> On 12/06/2015 09:47 PM, Geyslan G. Bem wrote:
>> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not unmapping correctly.
>>
>> Coccinelle: scripts/coccinelle/free/iounmap.cocci
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>>  drivers/usb/host/pci-quirks.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index f940056..64150dd 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>>                       /* We're reading garbage from the controller */
>>                       dev_warn(&pdev->dev,
>>                                "xHCI controller failing to respond");
>> -                     return;
>> +                     goto out;
>
> If "out" is only used here, why not iounmap and return directly here?
Could be directly. I just think that code recurrence can make things
complicated in future. What do you think?

Ah, seems that this patch is not aligned with linux-next. I'll make a
new one soon.

>
>>               }
>>
>>               if (!ext_cap_offset)
>> @@ -1062,6 +1062,7 @@ hc_init:
>>                        XHCI_MAX_HALT_USEC, val);
>>       }
>>
>> +out:
>>       iounmap(base);
>>  }
>>
>



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: host: iounmap before return "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-06 14:50 +0100
  Re: [PATCH] usb: host: iounmap before return Lu Baolu <baolu.lu@linux.intel.com> - 2015-12-07 10:40 +0100
    Re: [PATCH] usb: host: iounmap before return "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-07 11:30 +0100
    Re: [PATCH] usb: host: iounmap before return Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-07 12:40 +0100
      Re: [PATCH] usb: host: iounmap before return "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-08 00:50 +0100

csiph-web