[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown

From	Soren Brinkmann <soren.brinkmann@xilinx.com>
Newsgroups	linux.kernel
Subject	[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown
Date	2015-12-06 05:50 +0100
Message-ID	<qCzqO-2b5-23@gated-at.bofh.it> (permalink)
References	<qCzqN-2b5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When shutting down the UART, clear the interrupt status register. Bits
in the ISR are cleared by writing them as '1'.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
---
v4:
 - clarify workings of the ISR in the commit message
---
 drivers/tty/serial/xilinx_uartps.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 6a7cd4e057ae..ef114d7a0623 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -828,6 +828,7 @@ static void cdns_uart_shutdown(struct uart_port *port)
 	/* Disable interrupts */
 	status = readl(port->membase + CDNS_UART_IMR_OFFSET);
 	writel(status, port->membase + CDNS_UART_IDR_OFFSET);
+	writel(0xffffffff, port->membase + CDNS_UART_ISR_OFFSET);
 
 	/* Disable the TX and RX */
 	writel(CDNS_UART_CR_TX_DIS | CDNS_UART_CR_RX_DIS,
-- 
2.6.3.3.g9bb996a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-06 05:50 +0100

csiph-web