Re: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function

From	Sören Brinkmann <soren.brinkmann@xilinx.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function
Date	2015-12-05 22:50 +0100
Message-ID	<qCsSm-6q9-5@gated-at.bofh.it> (permalink)
References	<qxt2F-5Ri-3@gated-at.bofh.it> <qxt2F-5Ri-7@gated-at.bofh.it> <qCp85-44S-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2015-12-05 at 12:40PM -0500, Peter Hurley wrote:
> On 11/21/2015 09:59 PM, Soren Brinkmann wrote:
> > Move RX-related IRQ handling into a helper function.
> Fixes a problem where every char received after a parity or frame error
> in the current isr will also be tagged as a parity or frame error.
> 
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

Thanks. I'll add your text to the commit message.

> 
> NB: the sysrq problem in cdns_uart_isr() with needing to drop the
> locks is because cdns_uart_console_write() tries to take the port->lock.
> The 8250 driver handles this problem by not trying to take the
> port->lock if port->sysrq is non-zero. See serial8250_console_write().

I'll look into this. I'll see if I can include that in the next
iteration of this series or do it later.

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper  function Peter Hurley <peter@hurleysoftware.com> - 2015-12-05 18:50 +0100
  Re: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper  function Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-05 22:50 +0100

csiph-web