Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1284508

Re: [PATCH] fixdep: constify strrcmp arguments

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Newsgroups linux.kernel
Subject Re: [PATCH] fixdep: constify strrcmp arguments
Date Sat, 05 Dec 2015 10:50:02 +0100
Message-ID <qChDA-7KX-11@gated-at.bofh.it> (permalink)
References <qwfl9-6tM-45@gated-at.bofh.it>
X-Original-To Michal Marek <mmarek@suse.com>, linux-kbuild@vger.kernel.org
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=bw9uKTT52mFJpkfJCQABpmm8xkR1P7Lf6fOqdYg1uWk=; b=RNsqbcLameZpLHz/noXwF3gyuVHaRIlB8a6tydkG0nnwwGBVy4dYsqT/no8BaDAfO4 vWbzhXuH43azRYbNG2Ny8AM6Nnce8k9Kl0W63wyURkU3LQ1Pwht+NKGQ0/Ujwqte2tph awfxabwl+G1hJq3ufaB7+RYhjQmKBdE/B5G8TnSnwj8RQJWF8UukFs2hd8ToK9yZOTvU I8/Xq/bsTJh7PrpM9v1fAoNSZQh5pxi33lTF3OjCnCw1dHQGfHlt3iWLl/+TAX7R7HbD 75PE9pHOKVERQQQUvvLPvj/7IQA7Ex87ul8Gvc7tGp58kyCR1KBGfmxhiWM7r7V0kApv u19w==
X-Received by 10.28.15.146 with SMTP id 140mr9294799wmp.79.1449308614590; Sat, 05 Dec 2015 01:43:34 -0800 (PST)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Date Sat, 5 Dec 2015 10:43:32 +0100
X-Original-Message-ID <5662B1C4.5050104@m4x.org>
X-Original-References <1447870035-14677-1-git-send-email-nicolas.iooss_linux@m4x.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1284508

Show key headers only | View raw


Hello,
I sent the path below a few weeks ago and did not have any feedback.
Could you please review it?

Thanks,
Nicolas

On 11/18/2015 07:07 PM, Nicolas Iooss wrote:
> strrcmp only performs read access to the memory addressed by its
> arguments so make them const pointers.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  scripts/basic/fixdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
> index c68fd61fdc42..5b327c67a828 100644
> --- a/scripts/basic/fixdep.c
> +++ b/scripts/basic/fixdep.c
> @@ -251,7 +251,7 @@ static void parse_config_file(const char *map, size_t len)
>  }
>  
>  /* test is s ends in sub */
> -static int strrcmp(char *s, char *sub)
> +static int strrcmp(const char *s, const char *sub)
>  {
>  	int slen = strlen(s);
>  	int sublen = strlen(sub);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] fixdep: constify strrcmp arguments Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2015-12-05 10:50 +0100
  Re: [PATCH] fixdep: constify strrcmp arguments Michal Marek <mmarek@suse.com> - 2015-12-07 14:10 +0100

csiph-web