Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1284456

Re: [PATCH] clk: fix codying style of if ... else blocks

Show all headers | View raw

Hi Stephen,

No value for this patch, or just you missed this?


2015-11-05 17:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> This code is unreadable due to the blank line between if and else
> blocks.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/clk/clk-mux.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
> index 7129c86..5ed03c8 100644
> --- a/drivers/clk/clk-mux.c
> +++ b/drivers/clk/clk-mux.c
> @@ -71,10 +71,9 @@ static int clk_mux_set_parent(struct clk_hw *hw, u8 index)
>         u32 val;
>         unsigned long flags = 0;
>
> -       if (mux->table)
> +       if (mux->table) {
>                 index = mux->table[index];
> -
> -       else {
> +       } else {
>                 if (mux->flags & CLK_MUX_INDEX_BIT)
>                         index = 1 << index;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] clk: fix codying style of if ... else blocks Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-12-05 06:20 +0100

csiph-web