Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285085
| From | "Yankejian (Hackim Yim)" <yankejian@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage |
| Date | 2015-12-07 09:40 +0100 |
| Message-ID | <qCZuW-24d-9@gated-at.bofh.it> (permalink) |
| References | <qCfip-5IW-7@gated-at.bofh.it> <qCUEV-7tC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2015/12/7 11:29, David Miller wrote:
> From: yankejian <yankejian@huawei.com>
> Date: Sat, 5 Dec 2015 15:32:29 +0800
>
>> +#if (PAGE_SIZE < 8192)
>> + if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) {
>> + truesize = hnae_buf_size(ring);
>> + } else {
>> + truesize = ALIGN(size, L1_CACHE_BYTES);
>> + last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
>> + }
>> +
>> +#else
>> + truesize = ALIGN(size, L1_CACHE_BYTES);
>> + last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
>> +#endif
> This is not indented properly, and it looks terrible.
>
> .
>
Hi David,
Thanks for pointing it out. i will pay attention next time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage yankejian <yankejian@huawei.com> - 2015-12-05 08:20 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage David Miller <davem@davemloft.net> - 2015-12-07 04:30 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage Joe Perches <joe@perches.com> - 2015-12-07 04:40 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-07 10:00 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage Joe Perches <joe@perches.com> - 2015-12-07 10:10 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-07 10:30 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-07 09:40 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Du, Fan" <fan.du@intel.com> - 2015-12-07 10:00 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-08 07:30 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Du, Fan" <fan.du@intel.com> - 2015-12-08 07:40 +0100
Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-08 08:00 +0100
csiph-web