Re: [PATCH v2 1/2] um: Set secure access mode for temporary file

From	Mickaël Salaün <mic@digikod.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] um: Set secure access mode for temporary file
Date	2015-12-06 16:00 +0100
Message-ID	<qCIX8-8d3-15@gated-at.bofh.it> (permalink)
References	<qAaPU-7a0-3@gated-at.bofh.it> <qAaPV-7a0-11@gated-at.bofh.it> <qC2bw-5CT-17@gated-at.bofh.it> <qCG8V-6sD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 06/12/2015 12:32, Mickaël Salaün wrote:
> On 04/12/2015 18:13, Tristan Schmelcher wrote:
>> If there is a concern that the mkstemp implementation may be insecure,
>> why not set and restore the umask?
>>
> 
> I will add this safeguard.

Well, I'm concerned to use umask because it is not thread-safe and drivers may use create_mem_file() in a multi-theaded context. I prefer to stick to fchmod and handle the race-condition with O_TMPFILE unsell someone is sure that this will not create bugs :)

 Mickaël

Thread

Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Tristan Schmelcher <tschmelcher@google.com> - 2015-12-04 18:20 +0100
  Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Mickaël Salaün <mic@digikod.net> - 2015-12-06 13:00 +0100
  Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Mickaël Salaün <mic@digikod.net> - 2015-12-06 13:20 +0100
    Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Mickaël Salaün <mic@digikod.net> - 2015-12-06 16:00 +0100
      Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Tristan Schmelcher <tschmelcher@google.com> - 2015-12-08 21:40 +0100
        Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Richard Weinberger <richard@nod.at> - 2015-12-08 22:50 +0100
          Re: [PATCH v2 1/2] um: Set secure access mode for temporary file Mickaël Salaün <mic@digikod.net> - 2015-12-10 01:00 +0100

csiph-web