Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed
Date	2015-12-05 02:10 +0100
Message-ID	<qC9wm-1TA-19@gated-at.bofh.it> (permalink)
References	<qBgzU-8k6-11@gated-at.bofh.it> <qBo4p-4OQ-15@gated-at.bofh.it> <qBy3M-2WY-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 3 Dec 2015 10:08:26 +0100 Michal Hocko <mhocko@kernel.org> wrote:

> So you think a comment would be sufficient?
> ---
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 98a1934493af..2e8ee9e5fcb5 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1031,9 +1031,12 @@ static unsigned long shrink_page_list(struct list_head *page_list,
>  				/*
>  				 * We've got killed while waiting here so
>  				 * expedite our way out from the reclaim
> +				 *
> +				 * Our callers should make sure we do not
> +				 * get here with fatal signals again.
>  				 */

Seems OK.  s/should/must/

Please resend it all after the usual exhaustive testing ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] memcg, vmscan: Do not wait for writeback if killed Michal Hocko <mhocko@kernel.org> - 2015-12-02 15:30 +0100
  Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed Andrew Morton <akpm@linux-foundation.org> - 2015-12-02 23:30 +0100
    Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed Michal Hocko <mhocko@kernel.org> - 2015-12-03 10:10 +0100
      Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed Andrew Morton <akpm@linux-foundation.org> - 2015-12-05 02:10 +0100

csiph-web