Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put
Date	2015-12-05 01:50 +0100
Message-ID	<qC9d0-1wZ-15@gated-at.bofh.it> (permalink)
References	<qwjf4-Ju-5@gated-at.bofh.it> <qwjf4-Ju-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Nov 18, 2015 at 11:04:14PM +0100, Julia Lawall wrote:
> for_each_matching_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression e,e1;
> local idexpression np;
> @@
> 
>  for_each_matching_node(np, e1) {
>    ... when != of_node_put(np)
>        when != e = np
> (
>    return np;
> |
> +  of_node_put(np);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put Sebastian Reichel <sre@kernel.org> - 2015-12-05 01:50 +0100

csiph-web