Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1284248

Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs
Date 2015-12-04 22:40 +0100
Message-ID <qC6f8-88D-7@gated-at.bofh.it> (permalink)
References <qC3AB-6ol-5@gated-at.bofh.it> <qC3AB-6ol-3@gated-at.bofh.it> <qC43D-6Pk-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Friday 04 December 2015 11:12:30 Eric Dumazet wrote:
> On Fri, 2015-12-04 at 19:45 +0100, Gregory CLEMENT wrote:
> > With this patch each CPU is associated with its own set of TX queues. In
> > the same time the SKB received in mvneta_tx is bound to the queue
> > associated to the CPU sending the data. Thanks to this the next IRQ will
> > be received on the same CPU allowing sending more data.
> > 
> > It will also allow to have a more predictable behavior regarding
> > throughput and latency when having multiple threads sending out data on
> > different CPUs.
> > 
> > As an example on Armada XP GP, with an iperf bound to a CPU and a ping
> > bound to another CPU, without this patch the ping round trip was about
> > 2.5ms (and could reach 3s!), whereas with this patch it was around
> > 0.7ms (and sometime it went to 1.2ms).
> 
> This really looks like you need something smarter than pfifo_fast qdisc,
> and maybe BQL (I did not check if this driver already implements this)

I suggested this change as well as the BQL implementation that Marcin did.
I believe he hasn't posted that yet while he's doing some more testing,
but it should come soon.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-12-04 19:50 +0100
  Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues  management on all CPUs Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-04 20:20 +0100
    Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs Arnd Bergmann <arnd@arndb.de> - 2015-12-04 22:40 +0100
  Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues  management on all CPUs Marcin Wojtas <mw@semihalf.com> - 2015-12-05 20:20 +0100
    Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues  management on all CPUs David Miller <davem@davemloft.net> - 2015-12-05 23:30 +0100

csiph-web