Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1283970

Re: [PATCH v5 4/4] gpio: tps65086: Add GPO driver for the TPS65086 PMIC

From "Andrew F. Davis" <afd@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 4/4] gpio: tps65086: Add GPO driver for the TPS65086 PMIC
Date 2015-12-04 17:20 +0100
Message-ID <qC1fs-50Q-1@gated-at.bofh.it> (permalink)
References <qAZz4-5UF-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/01/2015 02:16 PM, kbuild test robot wrote:
> Hi Andrew,
>
> [auto build test ERROR on next-20151127]
> [cannot apply to ljones-mfd/for-mfd-next gpio/for-next v4.4-rc3 v4.4-rc2 v4.4-rc1 v4.4-rc3]
>
> url:    https://github.com/0day-ci/linux/commits/Andrew-F-Davis/Documentation-tps65086-Add-DT-bindings-for-the-TPS65086-PMIC/20151202-024903
> config: i386-allmodconfig (attached as .config)
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>     drivers/gpio/gpio-tps65086.c: In function 'tps65086_gpio_probe':
>>> drivers/gpio/gpio-tps65086.c:106:12: error: 'struct gpio_chip' has no member named 'parent'
>       gpio->chip.parent = gpio->tps->dev;
>                 ^
>
> vim +106 drivers/gpio/gpio-tps65086.c
>
>     100			return -ENOMEM;
>     101	
>     102		platform_set_drvdata(pdev, gpio);
>     103	
>     104		gpio->tps = dev_get_drvdata(pdev->dev.parent);
>     105		gpio->chip = template_chip;
>   > 106		gpio->chip.parent = gpio->tps->dev;
>     107	
>     108		ret = gpiochip_add(&gpio->chip);
>     109		if (ret < 0) {
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>

I'm probably going to drop the GPIO support in the next series push, this
patch was NAK'd for not using .parent, now we have this. I will wait till
the GPIO subsystem is stable and push this separately then.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v5 4/4] gpio: tps65086: Add GPO driver for the TPS65086  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-12-04 17:20 +0100

csiph-web